Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21912#discussion_r210539249
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -735,70 +735,92 @@ class CodegenContext {
}
/**
- * Generates code creating a [[UnsafeArrayData]].
+ * Generates code of setter for an [[ArrayData]]
+ *
+ * @param elementType data type of the elements in an [[ArrayData]]
+ *
+ * @return code representing a setter of an assignment for an
[[ArrayData]]
+ */
+ def setArrayElementFunc(dataType: DataType): String = {
--- End diff --
We should have this in `object CodeGenerator`?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
