Github user mn-mikke commented on a diff in the pull request:
https://github.com/apache/spark/pull/22126#discussion_r210724650
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/HigherOrderFunctionsSuite.scala
---
@@ -363,9 +363,9 @@ class HigherOrderFunctionsSuite extends SparkFunSuite
with ExpressionEvalHelper
left: Expression,
right: Expression,
f: (Expression, Expression, Expression) => Expression): Expression
= {
- val MapType(kt, vt1, vcn1) = left.dataType.asInstanceOf[MapType]
- val MapType(_, vt2, vcn2) = right.dataType.asInstanceOf[MapType]
- MapZipWith(left, right, createLambda(kt, false, vt1, vcn1, vt2,
vcn2, f))
+ val MapType(kt, vt1, _) = left.dataType.asInstanceOf[MapType]
--- End diff --
Optional suggestion: Maybe we could remove```asInstanceOf[MapType]``` here?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
