Github user chenghao-intel commented on a diff in the pull request:
https://github.com/apache/spark/pull/3139#discussion_r20051763
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveComparisonTest.scala
---
@@ -341,12 +341,21 @@ abstract class HiveComparisonTest
val query = new TestHive.HiveQLQueryExecution(queryString)
try { (query, prepareAnswer(query, query.stringResult())) }
catch {
case e: Throwable =>
+ val logicalQueryInString = try {
+ query.toString
--- End diff --
See
```
protected abstract class QueryExecution {
...
override def toString: String =
s"""== Parsed Logical Plan ==
|${stringOrError(logical)}
|== Analyzed Logical Plan ==
|${stringOrError(analyzed)}
|== Optimized Logical Plan ==
|${stringOrError(optimizedPlan)}
|== Physical Plan ==
|${stringOrError(executedPlan)}
|Code Generation: ${executedPlan.codegenEnabled}
|== RDD ==
""".stripMargin.trim
}
```
`logical`, `analyzed` etc. will be computed(which probably cause exception)
before passing into `stringOrError`, not happen inside of `stringOrError`.
Or you think we'd better to fix the `toString` here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
