GitHub user maropu opened a pull request:
https://github.com/apache/spark/pull/22154
[SPARK-23711][SPARK-25140][SQL] Catch correct exceptions when expr codegen
fails
## What changes were proposed in this pull request?
This pr is to fix bugs when expr codegen fails; we need to catch
`java.util.concurrent.ExecutionException` instead of
`InternalCompilerException` and `CompileException` . This handling is the same
with the `WholeStageCodegenExec ` one:
https://github.com/apache/spark/blob/60af2501e1afc00192c779f2736a4e3de12428fa/sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala#L585
## How was this patch tested?
Added tests in `CodeGeneratorWithInterpretedFallbackSuite`
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/maropu/spark SPARK-25140
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/22154.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #22154
----
commit b31dd28afbdd8d1078d9acf7785c18dc55afd9c2
Author: Takeshi Yamamuro <yamamuro@...>
Date: 2018-08-20T15:11:45Z
Fix
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
