Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22154#discussion_r211443069
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/CodeGeneratorWithInterpretedFallback.scala
---
@@ -63,7 +49,10 @@ abstract class CodeGeneratorWithInterpretedFallback[IN,
OUT] {
try {
createCodeGeneratedObject(in)
} catch {
- case CodegenError(_) => createInterpretedObject(in)
+ case _: Exception =>
+ // We should have already see error message in `CodeGenerator`
+ logError("Expr codegen disabled and falls back to the
interpreter mode")
--- End diff --
`logWarning` instead of `logError`? It uses `logWarning` in
`WholeStageCodegenExec` too.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
