Github user aarondav commented on a diff in the pull request:
https://github.com/apache/spark/pull/3172#discussion_r20056740
--- Diff:
network/shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalShuffleBlockManager.java
---
@@ -56,16 +58,24 @@
// Single-threaded Java executor used to perform expensive recursive
directory deletion.
private final Executor directoryCleaner;
- public ExternalShuffleBlockManager() {
+ private final TransportConf conf;
+
+ public ExternalShuffleBlockManager(TransportConf conf) {
// TODO: Give this thread a name.
- this(Executors.newSingleThreadExecutor());
+ this(Executors.newSingleThreadExecutor(), conf);
}
// Allows tests to have more control over when directories are cleaned
up.
@VisibleForTesting
- ExternalShuffleBlockManager(Executor directoryCleaner) {
+ ExternalShuffleBlockManager(Executor directoryCleaner, TransportConf
conf) {
--- End diff --
nit: please make conf first parameter to be consistent with other classes
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
