Github user gengliangwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/22133#discussion_r211482149
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala
---
@@ -593,7 +592,6 @@ object DataSource extends Logging {
"org.apache.spark.ml.source.libsvm.DefaultSource" -> libsvm,
"org.apache.spark.ml.source.libsvm" -> libsvm,
"com.databricks.spark.csv" -> csv,
- "com.databricks.spark.avro" -> avro,
--- End diff --
@HyukjinKwon I did add it in the `backwardCompatibilityMap` at first. But
later on I find that the configuration won't be effective in run time, since
the `backwardCompatibilityMap` is a `val`. (We can change
`backwardCompatibilityMap` to method to resolve that.) Also the code looks ugly.
```
val ret = Map(...)
if(...) {
ret + k -> v
} else {
ret
}
// it would be worse if we have more configurations.
```
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
