Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/22154#discussion_r211565872
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CodeGeneratorWithInterpretedFallbackSuite.scala
---
@@ -40,4 +55,13 @@ class CodeGeneratorWithInterpretedFallbackSuite extends
SparkFunSuite with PlanT
assert(obj.isInstanceOf[InterpretedUnsafeProjection])
}
}
+
+ test("fallback to the interpreter mode") {
+ val input = Seq(IntegerType).zipWithIndex.map(x =>
BoundReference(x._2, x._1, true))
+ val fallback = CodegenObjectFactoryMode.FALLBACK.toString
+ withSQLConf(SQLConf.CODEGEN_FACTORY_MODE.key -> fallback) {
+ val obj = FailedCodegenProjection.createObject(input)
+ assert(obj.isInstanceOf[InterpretedUnsafeProjection])
--- End diff --
yea, we could. If other reviewers say +1, I'll update (either's fine to me).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
