Github user chenghao-intel commented on the pull request: https://github.com/apache/spark/pull/3173#issuecomment-62306671 That's really nice to have the Sort-Merge-Join, as we did meet some of join queries couldn't run completely in real cases. One high level comment on this, can we also keep the `ShuffleHashJoin`? It still can be faster than the Sort-Merge-Join in some cases, all we need is a configuration/strategy to map to different Join Operators. BTW: do you have any performance comparison result can be shared with us?
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org