Github user yifeih commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22146#discussion_r211999160
  
    --- Diff: 
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/KubernetesDriverBuilder.scala
 ---
    @@ -51,7 +57,13 @@ private[spark] class KubernetesDriverBuilder(
         provideJavaStep: (
           KubernetesConf[KubernetesDriverSpecificConf]
             => JavaDriverFeatureStep) =
    -    new JavaDriverFeatureStep(_)) {
    +    new JavaDriverFeatureStep(_),
    +    provideTemplateVolumeStep: (KubernetesConf[_ <: 
KubernetesRoleSpecificConf]
    +      => TemplateVolumeStep) =
    +    new TemplateVolumeStep(_),
    +    provideInitialSpec: KubernetesConf[KubernetesDriverSpecificConf]
    --- End diff --
    
    It's because we need the kubernetesClient now to load from the pod spec, 
and not just the KubernetesConf parameter


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to