Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/22136#discussion_r212069129 --- Diff: python/pyspark/ml/tests.py --- @@ -844,6 +844,28 @@ def test_string_indexer_from_labels(self): .select(model_default.getOrDefault(model_default.outputCol)).collect() self.assertEqual(len(transformed_list), 5) + def test_vector_size_hint(self): --- End diff -- This test doesn't test the 2 functions which were buggy. Could you please test those (and simplify the test if possible)? Thanks!
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org