Github user erikerlandson commented on a diff in the pull request:
https://github.com/apache/spark/pull/22146#discussion_r212438850
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala
---
@@ -225,6 +225,18 @@ private[spark] object Config extends Logging {
"Ensure that major Python version is either Python2 or Python3")
.createWithDefault("2")
+ val KUBERNETES_DRIVER_CONTAINER_NAME =
+ ConfigBuilder("spark.kubernetes.driver.containerName")
--- End diff --
@mccheah it raises interesting question: a user might use this feature to
add containers, e.g. side-car proxies, service mesh, etc. In fact, I'd want
users to be able to do this. If there *are* multiple containers defined, we may
need a convention for identifying which one is driver/executor. Alternatives
might include additive-only, like labels, or disallowing, but supporting this
seems very desirable.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
