Github user maropu commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22227#discussion_r212782576
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
    @@ -2554,7 +2554,27 @@ object functions {
        * @since 1.5.0
        */
       def split(str: Column, pattern: String): Column = withExpr {
    -    StringSplit(str.expr, lit(pattern).expr)
    +    StringSplit(str.expr, lit(pattern).expr, lit(-1).expr)
    +  }
    +
    +  /**
    +   * Splits str around pattern (pattern is a regular expression) up to 
`limit-1` times.
    --- End diff --
    
    Drop `up to `limit-1` times` in the first line? That's because the 
behaviour depends on values described below.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to