Github user yucai commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22197#discussion_r212788978
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFileFormat.scala
 ---
    @@ -377,7 +378,7 @@ class ParquetFileFormat
               // Collects all converted Parquet filter predicates. Notice that 
not all predicates can be
               // converted (`ParquetFilters.createFilter` returns an 
`Option`). That's why a `flatMap`
               // is used here.
    -          .flatMap(parquetFilters.createFilter(parquetSchema, _))
    +          .flatMap(parquetFilters.createFilter(parquetSchema, _, 
isCaseSensitive))
    --- End diff --
    
    Yes, that way is better.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to