Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/21968#discussion_r212799711
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/RowBasedHashMapGenerator.scala
---
@@ -44,6 +44,12 @@ class RowBasedHashMapGenerator(
groupingKeySchema, bufferSchema) {
override protected def initializeAggregateHashMap(): String = {
+ val numVarLenFields = groupingKeys.map(_.dataType).count {
--- End diff --
Nit: can't this just be `.count(!UnsafeRow.isFixedLength(_))`?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
