Github user dongjoon-hyun commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22198#discussion_r212807892
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveHints.scala
 ---
    @@ -47,20 +49,39 @@ object ResolveHints {
        *
        * This rule must happen before common table expressions.
        */
    -  class ResolveBroadcastHints(conf: SQLConf) extends Rule[LogicalPlan] {
    +  class ResolveBroadcastHints(conf: SQLConf, catalog: SessionCatalog) 
extends Rule[LogicalPlan] {
    --- End diff --
    
    Accordingly, we can use String instead of SessionCatalog.
    ```scala
    -  class ResolveBroadcastHints(conf: SQLConf, catalog: SessionCatalog) 
extends Rule[LogicalPlan] {
    +  class ResolveBroadcastHints(conf: SQLConf, currentDatabase: String) 
extends Rule[LogicalPlan] {
    ```


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to