Github user TomaszGaweda commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22249#discussion_r213232338
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
    @@ -2459,6 +2459,26 @@ object functions {
         StringTrimLeft(e.expr, Literal(trimString))
       }
     
    +  /**
    +    * Extracts a part from a URL.
    +    *
    +    * @group string_funcs
    +    * @since 2.4.0
    +    */
    +  def parse_url(url: Column, partToExtract: String): Column = withExpr {
    --- End diff --
    
    @HyukjinKwon I see now. Yeah, wrapping in  the `Column` will be necessary, 
at least no string concatenation will be required


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to