Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22205#discussion_r213370444
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/test/SharedSparkSession.scala ---
    @@ -35,10 +36,18 @@ trait SharedSparkSession
       with Eventually { self: Suite =>
     
       protected def sparkConf = {
    +    val excludeRules = if 
(getClass.getName.startsWith("org.apache.spark.sql")) {
    +      // exclude this rule because it reduces code coverage by collapsing 
whole
    +      // query plan into LocalRelation
    +      Seq(ConvertToLocalRelation.ruleName)
    +    } else {
    +      Nil
    +    }
         new SparkConf()
           .set("spark.hadoop.fs.file.impl", classOf[DebugFilesystem].getName)
           .set("spark.unsafe.exceptionOnMemoryLeak", "true")
           .set(SQLConf.CODEGEN_FALLBACK.key, "false")
    +      .set(SQLConf.OPTIMIZER_EXCLUDED_RULES.key, 
excludeRules.mkString(","))
    --- End diff --
    
    The same thing is needed for `TestHive`


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to