Github user steveloughran commented on the issue:

    https://github.com/apache/spark/pull/22186
  
    The latest patch builds locally
    
    Maven test outcome
    * lots of json missing method errors, clearly jackson version problems of 
some kind
    * I don't see log messages of hive shutdown appearing in the output, though 
after all the tests finish I do get a log showing the FS cleanup is going on
    
    ```
    18/08/28 22:09:58 INFO ShutdownHookManager: Shutdown hook called
    18/08/28 22:09:58 INFO ShutdownHookManager: Deleting directory 
...spark/sql/hive-thriftserver/target/tmp/
    ```
    
    I think it might be possible to actually test whether the shutdown hook was 
added by calling remove(hook) in a test and verifying that the hook was found, 
that is : it was registered. Some caching of the hook and a package-level 
removeHook method in the HiveServer, though wiring it all the way up to a test 
case would be tricky...


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to