GitHub user cclauss opened a pull request:
https://github.com/apache/spark/pull/22266
lint-python: Add flake8 tests to find Python syntax errors and undefiâ¦
â¦ned names
Add [flake8](http://flake8.pycqa.org) tests to find Python syntax errors
and undefined names.
__E901,E999,F821,F822,F823__ are the "_showstopper_" flake8 issues that can
halt the runtime with a SyntaxError, NameError, etc. Most other flake8 issues
are merely "style violations" -- useful for readability but they do not effect
runtime safety.
* F821: undefined name `name`
* F822: undefined name `name` in `__all__`
* F823: local variable name referenced before assignment
* E901: SyntaxError or IndentationError
* E999: SyntaxError -- failed to compile a file into an Abstract Syntax Tree
## What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
## How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration
tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise,
remove this)
Please review http://spark.apache.org/contributing.html before opening a
pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cclauss/spark patch-3
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/22266.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #22266
----
commit 129119803eacbca1a53384893424e4ae75774626
Author: cclauss <cclauss@...>
Date: 2018-08-29T09:46:38Z
lint-python: Add flake8 tests to find Python syntax errors and undefined
names
Add [flake8](http://flake8.pycqa.org) tests to find Python syntax errors
and undefined names.
__E901,E999,F821,F822,F823__ are the "_showstopper_" flake8 issues that can
halt the runtime with a SyntaxError, NameError, etc. Most other flake8 issues
are merely "style violations" -- useful for readability but they do not effect
runtime safety.
* F821: undefined name `name`
* F822: undefined name `name` in `__all__`
* F823: local variable name referenced before assignment
* E901: SyntaxError or IndentationError
* E999: SyntaxError -- failed to compile a file into an Abstract Syntax Tree
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
