Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/22237#discussion_r213885328
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/jsonExpressions.scala
---
@@ -554,18 +554,28 @@ case class JsonToStructs(
@transient
lazy val converter = nullableSchema match {
case _: StructType =>
- (rows: Seq[InternalRow]) => if (rows.length == 1) rows.head else null
+ (rows: Iterator[InternalRow]) => if (rows.hasNext) rows.next() else
null
case _: ArrayType =>
- (rows: Seq[InternalRow]) => rows.head.getArray(0)
+ (rows: Iterator[InternalRow]) => if (rows.hasNext)
rows.next().getArray(0) else null
case _: MapType =>
- (rows: Seq[InternalRow]) => rows.head.getMap(0)
+ (rows: Iterator[InternalRow]) => if (rows.hasNext)
rows.next().getMap(0) else null
}
- @transient
- lazy val parser =
- new JacksonParser(
- nullableSchema,
- new JSONOptions(options + ("mode" -> FailFastMode.name),
timeZoneId.get))
+ @transient lazy val parser = {
+ val parsedOptions = new JSONOptions(options, timeZoneId.get)
+ val mode = parsedOptions.parseMode
+ require(mode == PermissiveMode || mode == FailFastMode,
--- End diff --
I think we should move this verification into the constructor.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
