Github user srowen commented on the issue:
https://github.com/apache/spark/pull/22280
Yes, I set up these dirs and POM profile. The profile adds a source
directory for 2.12, that previously had 2.12-specific implementations. It
doesn't exist anymore, so adding these source dirs shouldn't do anything.
See
https://github.com/apache/spark/commit/ff8dcc1d4c684e1b68e63d61b3f20284b9979cca
for the work that unified this, although we still have a separate dir for
2.11-only code now, that can't be removed.
The problem is really that we (I) forgot in the review that removing the
2.12-specific profile means we fail to override the "extra.source.dirs" that
should only exist for 2.11!
So yes your fix is right for that reason. It's a little odd to refer to the
old dirs that don't exist. I wonder if just setting the property values to
blank strings in the 2.12 profile works as well?
Really, what we should have is a scala-2.11 profile that adds the extra
source dirs only when 2.11 is building. That's cleaner, are you familiar with
how to write it? I can open a PR too.
CC @dbtsai
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
