Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21912#discussion_r214253824
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/ArrayData.scala 
---
    @@ -34,6 +36,32 @@ object ArrayData {
         case a: Array[Double] => UnsafeArrayData.fromPrimitiveArray(a)
         case other => new GenericArrayData(other)
       }
    +
    +
    +  /**
    +   * Allocate [[UnsafeArrayData]] or [[GenericArrayData]] based on given 
parameters.
    +   *
    +   * @param elementSize a size of an element in bytes
    +   * @param numElements the number of elements the array should contain
    +   * @param isPrimitiveType whether the type of an element is primitive 
type
    +   * @param additionalErrorMessage string to include in the error message
    +   */
    +  def allocateArrayData(
    +      elementSize: Int,
    --- End diff --
    
    ah it's called in the generated code. Maybe we can use elementSize `-1` to 
create a generic array.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to