Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22179#discussion_r214480126
  
    --- Diff: pom.xml ---
    @@ -1770,6 +1770,10 @@
                 <groupId>org.apache.hive</groupId>
                 <artifactId>hive-storage-api</artifactId>
               </exclusion>
    +          <exclusion>
    +            <groupId> com.esotericsoftware</groupId>
    +            <artifactId>kryo-shaded</artifactId>
    --- End diff --
    
    I guess my question is whether Orc complied against kryo-shaded 3.x 
necessarily works with kryo-shaded 4.x, because there were API and behavior 
changes. Our current tests don't seem to surface any such problems, but who 
knows if there's something they don't test.
    
    I agree that our distribution won't include two versions, but the issue I'm 
wondering about is whether Orc will like the one later version that it gets 
bundled with.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to