Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22192#discussion_r214485930
  
    --- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala ---
    @@ -136,6 +136,15 @@ private[spark] class Executor(
       // for fetching remote cached RDD blocks, so need to make sure it uses 
the right classloader too.
       env.serializerManager.setDefaultClassLoader(replClassLoader)
     
    +  private val pluginList = conf.get(EXECUTOR_PLUGINS)
    +  if (pluginList != Nil) logDebug(s"Loading the following plugins: 
${pluginList.mkString(", ")}")
    --- End diff --
    
    `pluginList.nonEmpty`
    
    Also we generally use the full syntax with braces, unless it's a one line 
`if..else`.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to