Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22317#discussion_r214556466
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -1623,12 +1623,13 @@ case class ArraysOverlap(left: Expression, right:
Expression)
val set = ctx.freshName("set")
val addToSetFromSmallerCode = nullSafeElementCodegen(
smaller, i, s"$set.add($getFromSmaller);", s"${ev.isNull} = true;")
+ val setIsNullCode = if (nullable) s"${ev.isNull} = false;" else ""
val elementIsInSetCode = nullSafeElementCodegen(
--- End diff --
There are calls to `nullSafeElementCodegen` in `bruteForceCodegen`, for
example, we don't need to fix them?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
