Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/22314#discussion_r214565371
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -1047,7 +1047,8 @@ trait ArraySortLike extends ExpectsInputTypes {
s"int $c = ${ctx.genComp(elementType, s"(($jt) $o1)", s"(($jt)
$o2)")};"
}
val nonNullPrimitiveAscendingSort =
- if (CodeGenerator.isPrimitiveType(elementType) && !containsNull) {
+ if (CodeGenerator.isPrimitiveType(elementType) && elementType !=
BooleanType
+ && !containsNull) {
--- End diff --
How about making this condition a separate method like
`isFastSortSupported`?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
