Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/22311#discussion_r214570600
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -515,8 +515,7 @@ object PushProjectionThroughUnion extends
Rule[LogicalPlan] with PredicateHelper
*/
object ColumnPruning extends Rule[LogicalPlan] {
private def sameOutput(output1: Seq[Attribute], output2:
Seq[Attribute]): Boolean =
- output1.size == output2.size &&
- output1.zip(output2).forall(pair => pair._1.semanticEquals(pair._2))
+ output1.size == output2.size && output1.zip(output2).forall(pair =>
pair._1 == pair._2)
--- End diff --
I think still we need to check if the exprIds that they refere to are the
same.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
