Github user kiszk commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22335#discussion_r215149786
  
    --- Diff: 
core/src/main/scala/org/apache/spark/status/AppStatusListener.scala ---
    @@ -646,8 +646,17 @@ private[spark] class AppStatusListener(
       }
     
       override def onUnpersistRDD(event: SparkListenerUnpersistRDD): Unit = {
    -    liveRDDs.remove(event.rddId)
    -    kvstore.delete(classOf[RDDStorageInfoWrapper], event.rddId)
    +    while (true) {
    --- End diff --
    
    This code may never cause infinite loop.
    Since `liveRDDs` is just a `HashMap` (not a `concurrentHashMap` or others), 
update by other threads may not be visible in this loop.



---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to