Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22350#discussion_r215812113
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFileFormat.scala
 ---
    @@ -123,6 +123,9 @@ class ParquetFileFormat
         // Sets compression scheme
         conf.set(ParquetOutputFormat.COMPRESSION, 
parquetOptions.compressionCodecClassName)
     
    +    // Sets Parquet block size
    +    conf.setInt(ParquetOutputFormat.BLOCK_SIZE, 
sparkSession.sessionState.conf.parquetBlockSize)
    --- End diff --
    
    I doubt if it is common enough to have an alias and document this in 
`sql-programming-guide.md`. Other configurations like `parquet.page.size`, 
`parquet.enable.dictionary` or `parquet.writer.version` are also rather 
similarly used as much as that configuration in my experience.
    
    I would add this for now.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to