Github user AndrewKL commented on the issue:
https://github.com/apache/spark/pull/22162
Hey Friends, I have updated the commit and fixed most of the issues
mentioned. I do have one remaining issue left which is the testing of the new
show functionality. Currently the provided private function to get the show
string takes in the new parameters given by the config so its impossible to
test the impact of the config changes. There's two possible ways to tackle
this. 1) leave the tests as is. 2) add in a spy library that would allow me to
inspect the input to the showString function. This would require adding a
library to test this. I wanted to get feed back on the preferred route before
I did this.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
