Github user holdenk commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22349#discussion_r216026421
  
    --- Diff: python/pyspark/ml/image.py ---
    @@ -207,6 +207,9 @@ def readImages(self, path, recursive=False, 
numPartitions=-1,
             .. note:: If sample ratio is less than 1, sampling uses a 
PathFilter that is efficient but
                 potentially non-deterministic.
     
    +        .. note:: Deprecated in 2.4.0. Use 
`spark.read.format("image").load(path)` instead and
    --- End diff --
    
    Would it make sense to issue a warning when people call this code path 
(e.g. `warnings.warn`)? We do it in some of the other Python deprecated APIs 
but not all.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to