Github user dongjoon-hyun commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22353#discussion_r216134032
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/DataSourceScanExec.scala 
---
    @@ -54,7 +54,7 @@ trait DataSourceScanExec extends LeafExecNode with 
CodegenSupport {
       override def simpleString: String = {
         val metadataEntries = metadata.toSeq.sorted.map {
           case (key, value) =>
    -        key + ": " + StringUtils.abbreviate(redact(value), 100)
    --- End diff --
    
    This seems to cause a regression on Spark Web UI. Could you check that, 
@LantaoJin ?
    
    In fact, the abbreviation is introduced over two years ago at Spark 2.0 
intentionally for UI via [[SPARK-14476][SQL] Improve the physical plan 
visualization by adding meta info like table name and file path for data 
source](https://github.com/apache/spark/pull/12947). At least, we had better 
update the information of PR and JIRA.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to