Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/22371#discussion_r216389817 --- Diff: core/src/main/scala/org/apache/spark/shuffle/IndexShuffleBlockResolver.scala --- @@ -138,13 +154,22 @@ private[spark] class IndexShuffleBlockResolver( mapId: Int, lengths: Array[Long], dataTmp: File): Unit = { + val mapLocks = shuffleIdToLocks.get(shuffleId) + require(mapLocks != null, "Shuffle should be registered to IndexShuffleBlockResolver first") + val lock = mapLocks.synchronized { --- End diff -- Oh I see, then your proposal could actually resolve the contention. With ConcurrentHashMap this synchronized block can be an updateIfAbsent call that might not even contend.
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org