Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22341#discussion_r216523989
  
    --- Diff: 
core/src/main/scala/org/apache/spark/status/AppStatusListener.scala ---
    @@ -646,7 +647,47 @@ private[spark] class AppStatusListener(
       }
     
       override def onUnpersistRDD(event: SparkListenerUnpersistRDD): Unit = {
    -    liveRDDs.remove(event.rddId)
    +    liveRDDs.remove(event.rddId).foreach { liveRDD =>
    +      val executorsToUpdate = new HashSet[LiveExecutor]()
    --- End diff --
    
    Right. But it would be nice to avoid the hash set if possible. The less 
stuff listeners have to do, the better.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to