Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22378#discussion_r216580577
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/InsertSuite.scala ---
@@ -750,4 +751,27 @@ class InsertSuite extends QueryTest with
TestHiveSingleton with BeforeAndAfter
}
}
}
+
+ Seq("LOCAL", "").foreach { local =>
+ Seq(true, false).foreach { caseSensitivity =>
+ Seq("orc", "parquet").foreach { format =>
+ test(s"SPARK-25389 INSERT OVERWRITE $local DIRECTORY ... STORED AS
with duplicated names" +
+ s"(caseSensitivity=$caseSensitivity, format=$format)") {
+ withTempDir { dir =>
+ withSQLConf(SQLConf.CASE_SENSITIVE.key -> s"$caseSensitivity")
{
+ val m = intercept[AnalysisException] {
+ sql(
+ s"""
+ |INSERT OVERWRITE $local DIRECTORY '${dir.toURI}'
+ |STORED AS $format
+ |SELECT 'id', 'id2' ${if (caseSensitivity) "id" else
"ID"}
--- End diff --
do we miss a comma after `'id2'`?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
