Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/22326#discussion_r216592676
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/FilterPushdownSuite.scala
---
@@ -1153,12 +1154,35 @@ class FilterPushdownSuite extends PlanTest {
"x.a".attr === Rand(10) && "y.b".attr === 5))
val correctAnswer =
x.where("x.a".attr === 5).join(y.where("y.a".attr === 5 &&
"y.b".attr === 5),
- condition = Some("x.a".attr === Rand(10)))
+ joinType = Cross).where("x.a".attr === Rand(10))
--- End diff --
cc @cloud-fan @gatorsmile for advice on this. It may probably be ok, as it
lets supporting a case which was not supported before. But I am not sure about
the added value as performing a cross join is often an impossible operation.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
