GitHub user Fokko opened a pull request:
https://github.com/apache/spark/pull/22399
[SPARK-25408] Move to mode ideomatic Java8
While working on another PR, I noticed that there is quite some legacy Java
in there that can be beautified. For example the use og features from Java8,
such as:
- Collection libraries
- Try-with-resource blocks
No code has been changed
What are your thoughts on this?
This makes code easier to read, and using try-with-resource makes is less
likely to forget to close something.
## What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
## How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration
tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise,
remove this)
Please review http://spark.apache.org/contributing.html before opening a
pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Fokko/spark SPARK-25408
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/22399.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #22399
----
commit 42050b540ce84063fab5d9e490e50e0eac802e94
Author: Fokko Driesprong <fokkodriesprong@...>
Date: 2018-09-11T20:37:33Z
[SPARK-25408] Move to mode ideomatic Java8
Use features from Java8 such as:
- Collection libraries
- Try-with-resource blocks
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
