Github user dongjoon-hyun commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22403#discussion_r217171729
  
    --- Diff: 
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/BooleanSimplificationSuite.scala
 ---
    @@ -37,6 +38,7 @@ class BooleanSimplificationSuite extends PlanTest with 
PredicateHelper {
           Batch("Constant Folding", FixedPoint(50),
             NullPropagation(conf),
             ConstantFolding,
    +        SimplifyConditionals,
             BooleanSimplification,
             PruneFilters(conf)) :: Nil
       }
    --- End diff --
    
    At line 46, SPARK-17851 changed like the following. We need that.
    ```scala
    - val testRelation = LocalRelation('a.int, 'b.int, 'c.int, 'd.string)
    + val testRelation = LocalRelation('a.int, 'b.int, 'c.int, 'd.string,
       'e.boolean, 'f.boolean, 'g.boolean, 'h.boolean)
    ```



---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to