Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/22375#discussion_r217368066 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvalHelper.scala --- @@ -223,8 +223,8 @@ trait ExpressionEvalHelper extends GeneratorDrivenPropertyChecks with PlanTestBa } } else { val lit = InternalRow(expected, expected) - val expectedRow = - UnsafeProjection.create(Array(expression.dataType, expression.dataType)).apply(lit) + val dtAsNullable = expression.dataType.asNullable + val expectedRow = UnsafeProjection.create(Array(dtAsNullable, dtAsNullable)).apply(lit) --- End diff -- Since this patch allows us to correctly detect incorrect results, I added a test that was passed w/o this patch and that is failed with this patch.
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org