Github user vanzin commented on the issue: https://github.com/apache/spark/pull/22325 If the test fails with your change you're introducing a change of behavior that breaks things, and you should fix it. I don't see why that is a reason for not merging both code paths. They're part of the same thing, it's just a matter of doing it correctly.
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org