Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22402#discussion_r217576877
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamingQuerySuite.scala
 ---
    @@ -460,9 +460,9 @@ class StreamingQuerySuite extends StreamTest with 
BeforeAndAfter with Logging wi
         val streamingInputDF = 
createSingleTriggerStreamingDF(streamingTriggerDF).toDF("value")
     
         val progress = 
getFirstProgress(streamingInputDF.join(streamingInputDF, "value"))
    -    assert(progress.numInputRows === 20) // data is read multiple times in 
self-joins
    --- End diff --
    
    The exchange reuse is not triggered here, because the project of one side 
is eliminated. In the kafka test, we have a cast in the project so Spark 
doesn't eliminate project ay any side, and the trigger exchange reuse.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to