Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/22396#discussion_r217722539
--- Diff: docs/sql-programming-guide.md ---
@@ -1898,6 +1898,7 @@ working with timestamps in `pandas_udf`s to get the
best performance, see
- Since Spark 2.4, File listing for compute statistics is done in
parallel by default. This can be disabled by setting
`spark.sql.parallelFileListingInStatsComputation.enabled` to `False`.
- Since Spark 2.4, Metadata files (e.g. Parquet summary files) and
temporary files are not counted as data files when calculating table size
during Statistics computation.
- Since Spark 2.4, empty strings are saved as quoted empty strings `""`.
In version 2.3 and earlier, empty strings are equal to `null` values and do not
reflect to any characters in saved CSV files. For example, the row of `"a",
null, "", 1` was writted as `a,,,1`. Since Spark 2.4, the same row is saved as
`a,,"",1`. To restore the previous behavior, set the CSV option `emptyValue` to
empty (not quoted) string.
+ - Since Spark 2.4 load command from local filesystem supports wildcards
in the folder level paths(e.g. LOAD DATA LOCAL INPATH 'tmp/folder*/). Now
onwards normal space convention can be used in folder/file names (e.g. LOAD
DATA INPATH 'tmp/folderName/file Name.csv), Older versions space in folder/file
names has been represented using '%20'(e.g. LOAD DATA INPATH
'tmp/folderName/myFile%20Name.csv), this usage will not be supported from spark
2.4 version.
--- End diff --
I think this text doesn't describe the change then. The new functionality
is that wildcards work at all levels in both local and remote file systems,
right? This also says that `%20` escaping used to work, but your results show
it didn't. That doesn't seem like a change in behavior. This text also has
typos and spacing problems. To be clear, here is the text I suggest:
Since Spark 2.4, the `LOAD DATA` command supports wildcard characters `?`
and `*`, which match any one character, and zero or more characters,
respectively. Example: `LOAD DATA INPATH '/tmp/folder*/` or `LOAD DATA INPATH
/tmp/part-?`. Characters like spaces also now work in paths: `LOAD DATA INPATH
`/tmp/folder name/`.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
