GitHub user kiszk opened a pull request:
https://github.com/apache/spark/pull/22439
[SPARK-25444][SQL] Refactor GenArrayData.genCodeToCreateArrayData method
## What changes were proposed in this pull request?
This PR makes `GenArrayData.genCodeToCreateArrayData` method simple by
using `ArrayData.createArrayData` method.
Before this PR, `genCodeToCreateArrayData` method was complicated
* Generated a temporary Java array to create `ArrayData`
* Had separate code generation path to assign values for `GenericArrayData`
and `UnsafeArrayData`
After this PR, the method
* Directly generates `GenericArrayData` or `UnsafeArrayData` without a
temporary array
* Has only code generation path to assign values
## How was this patch tested?
Existing UTs
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kiszk/spark SPARK-25444
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/22439.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #22439
----
commit 24fbf742fdd8490f57d29325100036e556847c77
Author: Kazuaki Ishizaki <ishizaki@...>
Date: 2018-09-17T05:28:00Z
initial commit
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
