Github user szyszy commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20761#discussion_r218087990
  
    --- Diff: 
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocator.scala
 ---
    @@ -275,9 +287,13 @@ private[yarn] class YarnAllocator(
           s"executorsStarting: ${numExecutorsStarting.get}")
     
         if (missing > 0) {
    -      logInfo(s"Will request $missing executor container(s), each with " +
    -        s"${resource.getVirtualCores} core(s) and " +
    -        s"${resource.getMemory} MB memory (including $memoryOverhead MB of 
overhead)")
    +      var requestContainerMessage = s"Will request $missing executor 
container(s), each with " +
    +          s"${resource.getVirtualCores} core(s) and " +
    +          s"${resource.getMemory} MB memory (including $memoryOverhead MB 
of overhead)"
    +      if (ResourceTypeHelper.isYarnResourceTypesAvailable()) {
    +        requestContainerMessage ++= s" with custom resources: " + 
resource.toString
    --- End diff --
    
    Yes, the nonEmpty check was missing. thanks


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to