GitHub user wangyum opened a pull request:

    https://github.com/apache/spark/pull/22443

    [SPARK-25339][TESTS] Refactor FilterPushdownBenchmark

    ## What changes were proposed in this pull request?
    
    Refactor `FilterPushdownBenchmark` use `main` method. we can use 3 ways to 
run this test now:
    
    1. bin/spark-submit --class 
org.apache.spark.sql.execution.benchmark.FilterPushdownBenchmark 
spark-sql_2.11-2.5.0-SNAPSHOT-tests.jar
    2. build/sbt "sql/test:runMain 
org.apache.spark.sql.execution.benchmark.FilterPushdownBenchmark"
    3. SPARK_GENERATE_BENCHMARK_FILES=1 build/sbt "sql/test:runMain 
org.apache.spark.sql.execution.benchmark.FilterPushdownBenchmark"
    
    The method 2 and the method 3 do not need to compile the 
`spark-sql_*-tests.jar` package. So these two methods are mainly for developers 
to quickly do benchmark.
    
    
    ## How was this patch tested?
    
    manual tests


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/wangyum/spark SPARK-25339

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/22443.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #22443
    
----
commit 7b50eb5225b664c43cd5dd66a49024741d2ca19c
Author: Yuming Wang <yumwang@...>
Date:   2018-09-17T16:51:03Z

    Refactor FilterPushdownBenchmark

commit 6e7cfc85d4d7719ee31254317b0ca81173be7128
Author: Yuming Wang <yumwang@...>
Date:   2018-09-17T16:53:55Z

    Revert numRows

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to