Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/13440#discussion_r218209825
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/tree/impurity/Gini.scala ---
@@ -71,6 +71,23 @@ object Gini extends Impurity {
@Since("1.1.0")
def instance: this.type = this
+ /**
+ * :: DeveloperApi ::
+ * p-values for test-statistic measures, unsupported for [[Gini]]
+ */
+ @Since("2.2.0")
+ @DeveloperApi
+ def calculate(calcL: ImpurityCalculator, calcR: ImpurityCalculator):
Double =
--- End diff --
It looks like this new method doesn't make sense to implement for existing
implementations, only the new one. That kind of suggests to me it isn't part of
the generic API for an impurity. Is this really something that belongs inside
the logic of the implementations? maybe there's a more general method that
needs to be exposed, that can then be specialized for all implementations.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
