Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/22173#discussion_r218462401
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/TransportContext.java
---
@@ -88,6 +97,16 @@ public TransportContext(
this.conf = conf;
this.rpcHandler = rpcHandler;
this.closeIdleConnections = closeIdleConnections;
+
+ synchronized(this.getClass()) {
--- End diff --
I think synchronized(this.getClass()) is not recommended due to it not
handling inheritance and such. Use synchronized(TransportContext.class)
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
