Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/22465#discussion_r218759101 --- Diff: sql/core/src/test/resources/sql-tests/inputs/operators.sql --- @@ -26,6 +26,15 @@ select 5 div 0; select 5 div null; select null div 5; +set spark.sql.legacy.integralDivide.returnBigint=true; + +select 5 div 2; +select 5 div 0; +select 5 div null; +select null div 5; + +set spark.sql.legacy.integralDivide.returnBigint=false; + --- End diff -- Too many unrelated changes in the output file, so IMO it'd be better to do so. But, its ok to wait for other reviews.
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org