Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/22173#discussion_r218926387
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/TransportContext.java
---
@@ -77,17 +82,43 @@
private static final MessageEncoder ENCODER = MessageEncoder.INSTANCE;
private static final MessageDecoder DECODER = MessageDecoder.INSTANCE;
+ // Separate thread pool for handling ChunkFetchRequest. This helps to
enable throttling
+ // max number of TransportServer worker threads that are blocked on
writing response
+ // of ChunkFetchRequest message back to the client via the underlying
channel.
+ private static EventLoopGroup chunkFetchWorkers;
+
public TransportContext(TransportConf conf, RpcHandler rpcHandler) {
- this(conf, rpcHandler, false);
+ this(conf, rpcHandler, false, false);
}
public TransportContext(
TransportConf conf,
RpcHandler rpcHandler,
boolean closeIdleConnections) {
+ this(conf, rpcHandler, closeIdleConnections, false);
+ }
+
+ public TransportContext(
+ TransportConf conf,
+ RpcHandler rpcHandler,
+ boolean closeIdleConnections,
+ boolean isClient) {
--- End diff --
we should make this more clear. Because with external shuffle off, we want
this on client mode as well since its really both a client and server. Perhaps
we could change name to be isClientOnly, we should put some java docs on the
function to describe the parameter as well.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
